Hi Andrey,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on usb/usb-testing]
[also build test WARNING on linus/master v5.7-rc3 next-20200428]
[cannot apply to balbi-usb/next peter.chen-usb/ci-for-usb-next]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    
https://github.com/0day-ci/linux/commits/Andrey-Konovalov/usb-raw-gadget-fix-gadget-endpoint-selection/20200429-060106
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git 
usb-testing
config: c6x-allyesconfig (attached as .config)
compiler: c6x-elf-gcc (GCC) 9.3.0
reproduce:
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=c6x 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <[email protected]>

All warnings (new ones prefixed by >>):

   drivers/usb/gadget/legacy/raw_gadget.c: In function 'raw_ioctl_eps_info':
>> drivers/usb/gadget/legacy/raw_gadget.c:1079:1: warning: the frame size of 
>> 1096 bytes is larger than 1024 bytes [-Wframe-larger-than=]
    1079 | }
         | ^

vim +1079 drivers/usb/gadget/legacy/raw_gadget.c

  1040  
  1041  static int raw_ioctl_eps_info(struct raw_dev *dev, unsigned long value)
  1042  {
  1043          int ret = 0, i;
  1044          unsigned long flags;
  1045          struct usb_raw_eps_info info;
  1046          struct raw_ep *ep;
  1047  
  1048          spin_lock_irqsave(&dev->lock, flags);
  1049          if (dev->state != STATE_DEV_RUNNING) {
  1050                  dev_dbg(dev->dev, "fail, device is not running\n");
  1051                  ret = -EINVAL;
  1052                  spin_unlock_irqrestore(&dev->lock, flags);
  1053                  goto out;
  1054          }
  1055          if (!dev->gadget) {
  1056                  dev_dbg(dev->dev, "fail, gadget is not bound\n");
  1057                  ret = -EBUSY;
  1058                  spin_unlock_irqrestore(&dev->lock, flags);
  1059                  goto out;
  1060          }
  1061  
  1062          memset(&info, 0, sizeof(info));
  1063          for (i = 0; i < dev->eps_num; i++) {
  1064                  ep = &dev->eps[i];
  1065                  strscpy(&info.eps[i].name[0], ep->ep->name,
  1066                                  USB_RAW_EP_NAME_MAX);
  1067                  info.eps[i].addr = ep->addr;
  1068                  fill_ep_caps(&ep->ep->caps, &info.eps[i].caps);
  1069                  fill_ep_limits(ep->ep, &info.eps[i].limits);
  1070          }
  1071          ret = dev->eps_num;
  1072          spin_unlock_irqrestore(&dev->lock, flags);
  1073  
  1074          if (copy_to_user((void __user *)value, &info, sizeof(info)))
  1075                  ret = -EFAULT;
  1076  
  1077  out:
  1078          return ret;
> 1079  }
  1080  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]

Attachment: .config.gz
Description: application/gzip

Reply via email to