Hi, On Tue, Apr 28, 2020 at 5:38 PM Joe Perches <[email protected]> wrote: > > On Tue, 2020-04-28 at 17:23 -0700, Douglas Anderson wrote: > > When I copied the function prototypes from the GPIO header file into > > my own driver, checkpatch yelled at me saying that I shouldn't use use > > "unsigned" but instead should say "unsigned int". Let's make the > > header file use "unsigned int" so others who copy like I did won't get > > yelled at. > > There are a few other unsigned declarations in the file.
There are? I swear I looked for them before I sent my patch and I couldn't find them. Then I looked again upon seeing your reply and I still can't find them. My eyes are bad, though. Maybe you can give me specifics? > Maybe do all of them (and remove the unnecessary externs)? You mean just remove the word "extern" everywhere in this file? Sure, I can if you want. > trivial reformatting of the function pointer block too Wow, I must be totally out of it. Maybe it's the gin and tonic I just had. I don't understand this comment either. Can you clarify? -Doug
