Re: [PATCH] ARM: dts: gw552x: add USB OTG support

[Shawn Guo]

On Fri, Apr 24, 2020 at 10:10:15AM -0700, Tim Harvey wrote:
> The GW552x-B board revision adds USB OTG support.
> 
> Enable the device-tree node and configure the OTG_ID pin.
> 
> Signed-off-by: Tim Harvey <thar...@gateworks.com>
> ---
>  arch/arm/boot/dts/imx6qdl-gw552x.dtsi | 16 ++++++++++++++--
>  1 file changed, 14 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-gw552x.dtsi 
> b/arch/arm/boot/dts/imx6qdl-gw552x.dtsi
> index dc646b7..133a1e3 100644
> --- a/arch/arm/boot/dts/imx6qdl-gw552x.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-gw552x.dtsi
> @@ -12,8 +12,6 @@
>               led1 = &led1;
>               led2 = &led2;
>               nand = &gpmi;
> -             usb0 = &usbh1;
> -             usb1 = &usbotg;

Have some comments about this change in the commit log?

Shawn

>       };
>  
>       chosen {
> @@ -258,6 +256,14 @@
>       status = "okay";
>  };
>  
> +&usbotg {
> +     vbus-supply = <&reg_5p0v>;
> +     pinctrl-names = "default";
> +     pinctrl-0 = <&pinctrl_usbotg>;
> +     disable-over-current;
> +     status = "okay";
> +};
> +
>  &wdog1 {
>       pinctrl-names = "default";
>       pinctrl-0 = <&pinctrl_wdog>;
> @@ -359,6 +365,12 @@
>               >;
>       };
>  
> +     pinctrl_usbotg: usbotggrp {
> +             fsl,pins = <
> +                     MX6QDL_PAD_ENET_RX_ER__USB_OTG_ID       0x13059
> +             >;
> +     };
> +
>       pinctrl_wdog: wdoggrp {
>               fsl,pins = <
>                       MX6QDL_PAD_DISP0_DAT8__WDOG1_B          0x1b0b0
> -- 
> 2.7.4
>