Hello, I'm currently working on improvements in PF-VF handling on s390. One thing that may be a bit special for us is that the s390 hotplug code supports shutting down a single PF of a multi-function device such as a ConnectX-5. During testing I found that the mlx5_core driver does not call pci_disable_sriov() in its remove handler which is called on the PF via pci_stop_and_remove_bus_device() on an orderly hot unplug.
Following is a patch to fix this, I want to point out however that I'm not entirely sure about the effect of clear_vfs that distinguishes mlx5_sriov_detach() from mlx5_sriov_disable() only that the former is called from the remove handler and it doesn't call pci_disable_sriov(). That however is required according to Documentation/PCI/pci-iov-howto.rst I've only tested this on top of my currently still internal PF-VF rework so I might also be totally missing something here in that case excuse my ignorance. Best regards, Niklas Schnelle Niklas Schnelle (1): net/mlx5: Call pci_disable_sriov() on remove drivers/net/ethernet/mellanox/mlx5/core/sriov.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.17.1
