Re: [PATCH] i2c: cht-wc: Remove superfluous error message in cht_wc_i2c_adap_i2c_probe()

[Hans de Goede]

Hi,

On 5/3/20 3:23 PM, Aishwarya Ramakrishnan wrote:

The function platform_get_irq can log an error by itself.
This omit a redundant message for exception handling in the
calling function.

Suggested by Coccinelle.

Signed-off-by: Aishwarya Ramakrishnan <aishwaryarj...@gmail.com>

Thank you for the patch, patch looks good to me:

Reviewed-by: Hans de Goede <hdego...@redhat.com>

Regards,

Hans

---
  drivers/i2c/busses/i2c-cht-wc.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/i2c/busses/i2c-cht-wc.c b/drivers/i2c/busses/i2c-cht-wc.c
index 35e55feda763..343ae5754e6e 100644
--- a/drivers/i2c/busses/i2c-cht-wc.c
+++ b/drivers/i2c/busses/i2c-cht-wc.c
@@ -314,10 +314,8 @@ static int cht_wc_i2c_adap_i2c_probe(struct 
platform_device *pdev)
        int ret, reg, irq;

irq = platform_get_irq(pdev, 0);

-       if (irq < 0) {
-               dev_err(&pdev->dev, "Error missing irq resource\n");
+       if (irq < 0)
                return -EINVAL;
-       }

adap = devm_kzalloc(&pdev->dev, sizeof(*adap), GFP_KERNEL);

        if (!adap)