On Mon, May 04, 2020 at 05:14:06PM +0530, Aishwarya Ramakrishnan wrote: > The function platform_get_irq can log an error by itself. > This omit a redundant message for exception handling in the > calling function.
FWIW, Reviewed-by: Andy Shevchenko <[email protected]> > Suggested by Coccinelle. Compile tested only, right? > > Signed-off-by: Aishwarya Ramakrishnan <[email protected]> > --- > drivers/i2c/busses/i2c-altera.c | 4 +--- > drivers/i2c/busses/i2c-cht-wc.c | 4 +--- > drivers/i2c/busses/i2c-img-scb.c | 4 +--- > drivers/i2c/busses/i2c-lpc2k.c | 4 +--- > drivers/i2c/busses/i2c-uniphier.c | 4 +--- > 5 files changed, 5 insertions(+), 15 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-altera.c b/drivers/i2c/busses/i2c-altera.c > index f5c00f903df3..af6985f0ae63 100644 > --- a/drivers/i2c/busses/i2c-altera.c > +++ b/drivers/i2c/busses/i2c-altera.c > @@ -395,10 +395,8 @@ static int altr_i2c_probe(struct platform_device *pdev) > return PTR_ERR(idev->base); > > irq = platform_get_irq(pdev, 0); > - if (irq < 0) { > - dev_err(&pdev->dev, "missing interrupt resource\n"); > + if (irq < 0) > return irq; > - } > > idev->i2c_clk = devm_clk_get(&pdev->dev, NULL); > if (IS_ERR(idev->i2c_clk)) { > diff --git a/drivers/i2c/busses/i2c-cht-wc.c b/drivers/i2c/busses/i2c-cht-wc.c > index 35e55feda763..343ae5754e6e 100644 > --- a/drivers/i2c/busses/i2c-cht-wc.c > +++ b/drivers/i2c/busses/i2c-cht-wc.c > @@ -314,10 +314,8 @@ static int cht_wc_i2c_adap_i2c_probe(struct > platform_device *pdev) > int ret, reg, irq; > > irq = platform_get_irq(pdev, 0); > - if (irq < 0) { > - dev_err(&pdev->dev, "Error missing irq resource\n"); > + if (irq < 0) > return -EINVAL; > - } > > adap = devm_kzalloc(&pdev->dev, sizeof(*adap), GFP_KERNEL); > if (!adap) > diff --git a/drivers/i2c/busses/i2c-img-scb.c > b/drivers/i2c/busses/i2c-img-scb.c > index 422097a31c95..2f6de763816a 100644 > --- a/drivers/i2c/busses/i2c-img-scb.c > +++ b/drivers/i2c/busses/i2c-img-scb.c > @@ -1344,10 +1344,8 @@ static int img_i2c_probe(struct platform_device *pdev) > return PTR_ERR(i2c->base); > > irq = platform_get_irq(pdev, 0); > - if (irq < 0) { > - dev_err(&pdev->dev, "can't get irq number\n"); > + if (irq < 0) > return irq; > - } > > i2c->sys_clk = devm_clk_get(&pdev->dev, "sys"); > if (IS_ERR(i2c->sys_clk)) { > diff --git a/drivers/i2c/busses/i2c-lpc2k.c b/drivers/i2c/busses/i2c-lpc2k.c > index 13b0c12e2dba..43dc9b7043e4 100644 > --- a/drivers/i2c/busses/i2c-lpc2k.c > +++ b/drivers/i2c/busses/i2c-lpc2k.c > @@ -362,10 +362,8 @@ static int i2c_lpc2k_probe(struct platform_device *pdev) > return PTR_ERR(i2c->base); > > i2c->irq = platform_get_irq(pdev, 0); > - if (i2c->irq < 0) { > - dev_err(&pdev->dev, "can't get interrupt resource\n"); > + if (i2c->irq < 0) > return i2c->irq; > - } > > init_waitqueue_head(&i2c->wait); > > diff --git a/drivers/i2c/busses/i2c-uniphier.c > b/drivers/i2c/busses/i2c-uniphier.c > index 668b1fa2b0ef..ee00a44bf4c7 100644 > --- a/drivers/i2c/busses/i2c-uniphier.c > +++ b/drivers/i2c/busses/i2c-uniphier.c > @@ -324,10 +324,8 @@ static int uniphier_i2c_probe(struct platform_device > *pdev) > return PTR_ERR(priv->membase); > > irq = platform_get_irq(pdev, 0); > - if (irq < 0) { > - dev_err(dev, "failed to get IRQ number\n"); > + if (irq < 0) > return irq; > - } > > if (of_property_read_u32(dev->of_node, "clock-frequency", &bus_speed)) > bus_speed = I2C_MAX_STANDARD_MODE_FREQ; > -- > 2.17.1 > -- With Best Regards, Andy Shevchenko
