On Thu, May 07, 2020 at 01:23:52PM +0100, Bryan O'Donoghue wrote:
> Adds a MODULE_DEVICE_TABLE() to allow probing of this driver from a DTS
> setting.
>
> Cc: Heikki Krogerus <[email protected]>
> Cc: Greg Kroah-Hartman <[email protected]>
> Cc: Nikolaus Voss <[email protected]>
> Cc: Andy Shevchenko <[email protected]>
> Cc: Gustavo A. R. Silva <[email protected]>
> Cc: Kees Cook <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Signed-off-by: Bryan O'Donoghue <[email protected]>
> ---
> drivers/usb/typec/tps6598x.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/usb/typec/tps6598x.c b/drivers/usb/typec/tps6598x.c
> index 0698addd1185..61c6761072c9 100644
> --- a/drivers/usb/typec/tps6598x.c
> +++ b/drivers/usb/typec/tps6598x.c
> @@ -563,6 +563,14 @@ static int tps6598x_remove(struct i2c_client *client)
> return 0;
> }
>
> +#ifdef CONFIG_OF
No need for this (and thus for of_match_ptr() macro below). Saving few dozens
of bytes?
> +static const struct of_device_id tps6598x_of_match[] = {
> + { .compatible = "ti,tps6598x", },
> + {},
No comma for terminator line.
> +};
> +MODULE_DEVICE_TABLE(of, tps6598x_of_match);
> +#endif
> +
> static const struct i2c_device_id tps6598x_id[] = {
> { "tps6598x" },
> { }
> @@ -572,6 +580,7 @@ MODULE_DEVICE_TABLE(i2c, tps6598x_id);
> static struct i2c_driver tps6598x_i2c_driver = {
> .driver = {
> .name = "tps6598x",
> + .of_match_table = of_match_ptr(tps6598x_of_match),
--
With Best Regards,
Andy Shevchenko
