> Maybe dmc->df->lock is unnecessary to protect function > exynos5_dmc_perf_events_check(dmc). If we have to protect, > dmc->lock is more better and more effective. > Also, it seems not needed to protect "if (ret) & dev_warn" > branch.
I suggest to improve also this commit message. * Please reduce uncertainty. * An imperative wording is probably preferred, isn't it? * Will it be more appropriate to refer to the action “Reduce the lock scope”? * Would you like to add the tag “Fixes” to the change description? Regards, Markus
