On Fri, May 8, 2020 at 12:01 PM Grygorii Strashko
<[email protected]> wrote:
> +static int __init k3_chipinfo_init(void)
> +{
> + struct soc_device_attribute *soc_dev_attr;
> + struct soc_device *soc_dev;
> + struct device_node *node;
> + struct regmap *regmap;
> + u32 partno_id;
> + u32 variant;
> + u32 jtag_id;
> + u32 mfg;
> + int ret;
> +
> + node = of_find_compatible_node(NULL, NULL, "ti,am654-chipid");
> + if (!node)
> + return -ENODEV;
This will fail the initcall and print a warning when the kernel runs on any
other SoC. Would it be possible to just make this a platform_driver?
If not, I think you should silently return success when the device
node is absent.
Arnd
