> Subject: RE: [PATCH] dt-bindings: reset: Convert i.MX7 reset to json-schema
> 
> [...]
> 
> > +
> > +maintainers:
> > +  - Anson Huang <[email protected]>
> > +
> > +description: |
> > +  The system reset controller can be used to reset various set of
> > +  peripherals. Device nodes that need access to reset lines should
> > +  specify them as a reset phandle in their corresponding node as
> > +  specified in reset.txt.
> > +
> > +  For list of all valid reset indices see
> > +    <dt-bindings/reset/imx7-reset.h> for i.MX7,
> > +    <dt-bindings/reset/imx8mq-reset.h> for i.MX8MQ and
> > +    <dt-bindings/reset/imx8mq-reset.h> for i.MX8MM and
> > +    <dt-bindings/reset/imx8mq-reset.h> for i.MX8MN and
> 
> How about combine above three items?

Will do.

> 
> > +    <dt-bindings/reset/imx8mp-reset.h> for i.MX8MP
> > +
> > +properties:
> > +  compatible:
> > +    items:
> > +      - enum:
> > +        - fsl,imx7d-src
> > +        - fsl,imx8mq-src
> > +        - fsl,imx8mm-src
> > +        - fsl,imx8mn-src
> > +        - fsl,imx8mp-src
> > +      - const: syscon
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  '#reset-cells':
> > +    const: 1
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - interrupts
> > +  - '#reset-cells'
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +
> > +    reset-controller@30390000 {
> > +        compatible = "fsl,imx7d-src", "syscon";
> > +        reg = <0x30390000 0x2000>;
> > +        interrupts = <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>;
> > +        #reset-cells = <1>;
> > +    };
> > +
> > +...
> 
> Is this required?

It can be removed, will remove it in next version.

Anson

Reply via email to