On Mon, 2020-05-11 at 10:08 -0700, Jakub Kicinski wrote: > ENOTSUPP often feels like the right error code to use, but it's > in fact not a standard Unix error. E.g.: > > $ python > > > > import errno > > > > errno.errorcode[errno.ENOTSUPP] > Traceback (most recent call last): > File "<stdin>", line 1, in <module> > AttributeError: module 'errno' has no attribute 'ENOTSUPP' > > There were numerous commits converting the uses back to EOPNOTSUPP > but in some cases we are stuck with the high error code for backward > compatibility reasons. > > Let's try prevent more ENOTSUPPs from getting into the kernel. > > Recent example: > https://lore.kernel.org/netdev/[email protected]/ > > v3 (Joe): > - fix the "not file" condition. > > v2 (Joe): > - add a link to recent discussion, > - don't match when scanning files, not patches to avoid sudden > influx of conversion patches. > https://lore.kernel.org/netdev/[email protected]/ > > v1: > https://lore.kernel.org/netdev/[email protected]/ > > Suggested-by: Andrew Lunn <[email protected]> > Signed-off-by: Jakub Kicinski <[email protected]> > Acked-by: Joe Perches <[email protected]> > ---
Thanks. No worries here and it's not worth a respin, but typically the patch changelog goes below the --- line.
