On Wed, May 13, 2020 at 06:34:05PM +0300, Andy Shevchenko wrote:
> On Wed, May 13, 2020 at 06:46:15PM +0800, Ramuthevar,Vadivel MuruganX wrote:
...
> > +static int ebu_nand_remove(struct platform_device *pdev)
> > +{
> > + struct ebu_nand_controller *ebu_host = platform_get_drvdata(pdev);
> > +
>
> > + if (ebu_host) {
>
> How it can be NULL here?
>
> > + mtd_device_unregister(nand_to_mtd(&ebu_host->chip));
> > + nand_cleanup(&ebu_host->chip);
> > + ebu_nand_disable(&ebu_host->chip);
> > +
> > + if (ebu_host->dma_rx || ebu_host->dma_tx)
This is duplicate and thus redundant.
> > + ebu_dma_cleanup(ebu_host);
> > +
> > + clk_disable_unprepare(ebu_host->clk);
> > + }
> > +
> > + return 0;
> > +}
--
With Best Regards,
Andy Shevchenko
