Hi James, Patches all look good. Tested on AMD platform and working as expected.
Reviewed-by: Babu Moger <[email protected]> Thanks > -----Original Message----- > From: James Morse <[email protected]> > Sent: Thursday, April 30, 2020 12:04 PM > To: [email protected]; [email protected] > Cc: Fenghua Yu <[email protected]>; Reinette Chatre > <[email protected]>; Thomas Gleixner <[email protected]>; Ingo > Molnar <[email protected]>; Borislav Petkov <[email protected]>; H Peter Anvin > <[email protected]>; Moger, Babu <[email protected]>; James Morse > <[email protected]> > Subject: [PATCH v2 00/10] x86/resctrl: Misc cleanup > > Hello! > > These are the miscellaneous cleanup patches that floated to the top of > the MPAM tree. > > The only interesting thing are the patches to make the AMD/Intel > differences something resctrl understands, instead of just 'happening' > because of the different function pointers. > This will become more important once MPAM support is added. parse_bw() > and friends are what enforces resctrl's ABI resctrl. Allowing an > architecture/platform to provide a subtly different function here would > be bad for user-space. > > MPAM would set arch_has_sparse_bitmaps, but not arch_needs_linear. > > Since [v1], I've picked up all the review feedback and collected the > tags. > > Nothing in this series should change any behaviour. > This series is based on v5.7-rc3. > > Thanks, > > James > > [v1] > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.ker > nel.org%2Flkml%2F20200214182401.39008-1- > james.morse%40arm.com%2F&data=02%7C01%7CBabu.Moger%40amd.c > om%7C1d3c1ee27e204ebece3808d7ed288034%7C3dd8961fe4884e608e11a82d > 994e183d%7C0%7C0%7C637238630922264101&sdata=Gcfop8YPzsPFq8fk > bgnR%2FZgQApnQYVbaCdRlhpE2YPE%3D&reserved=0 > > James Morse (10): > x86/resctrl: Nothing uses struct mbm_state chunks_bw > x86/resctrl: Remove max_delay > x86/resctrl: Fix stale comment > x86/resctrl: use container_of() in delayed_work handlers > x86/resctrl: Include pid.h > x86/resctrl: Use is_closid_match() in more places > x86/resctrl: Add arch_needs_linear to explain AMD/Intel MBA difference > x86/resctrl: Merge AMD/Intel parse_bw() calls > x86/resctrl: Add arch_has_sparse_bitmaps to explain AMD/Intel CAT > difference > cacheinfo: Move resctrl's get_cache_id() to the cacheinfo header file > > arch/x86/kernel/cpu/resctrl/core.c | 35 +++------ > arch/x86/kernel/cpu/resctrl/ctrlmondata.c | 89 +++-------------------- > arch/x86/kernel/cpu/resctrl/internal.h | 19 ++--- > arch/x86/kernel/cpu/resctrl/monitor.c | 15 +--- > arch/x86/kernel/cpu/resctrl/rdtgroup.c | 32 ++++---- > include/linux/cacheinfo.h | 21 ++++++ > include/linux/resctrl.h | 2 + > 7 files changed, 70 insertions(+), 143 deletions(-) > > -- > 2.26.1
