On Tue, 2020-05-12 at 15:38 +0200, Wolfram Sang wrote:
> Hi Qii Wang,
>
> On Thu, Mar 26, 2020 at 07:54:36PM +0800, qii.w...@mediatek.com wrote:
> > From: Qii Wang <qii.w...@mediatek.com>
> >
> > This patch adds a algorithm to calculate some ac-timing parameters
> > which can fully meet I2C Spec.
> >
> > Signed-off-by: Qii Wang <qii.w...@mediatek.com>
>
> Could you rebase this on top of i2c/for-next or v5.7-rcX? Because of
> commit 90224e6468e1 ("i2c: drivers: Use generic definitions for bus
> frequencies") which was added two days before your patch was sent out.
>
> Otherwise mostly minor nits.
>
> > +static int mtk_i2c_max_step_cnt(unsigned int target_speed)
> > +{
> > + if (target_speed > MAX_FS_MODE_SPEED)
> > + return MAX_HS_STEP_CNT_DIV;
> > + else
> > + return MAX_STEP_CNT_DIV;
> > +}
>
> Maybe ternary operator here? Your choice.
>
Use ternary operator here will over 80 bytes, and need a line break,
Maybe this code looks simpler.
> And my code checkers complained:
>
> CPPCHECK
> drivers/i2c/busses/i2c-mt65xx.c:591:11: warning: Redundant assignment of
> 'sda_max' to itself. [selfAssignment]
> sda_max = sda_max;
> ^
> drivers/i2c/busses/i2c-mt65xx.c:597:11: warning: Redundant assignment of
> 'sda_min' to itself. [selfAssignment]
> sda_min = sda_min;
>
ok, I will modify it.
> Last question: You seem to be the one doing major updates to this
> driver. Thanks for that! Are you maybe interested in becoming the
> maintainer for this driver? I think there won't be much patches to
> review and reports to handle but it will speed up processing for me.
>
Yes, It is my honor to be the maintainer for this driver.
> All the best,
>
> Wolfram
>
