On May 14, 2020 8:07:59 PM GMT+02:00, Linus Torvalds <[email protected]> wrote: >On Thu, May 14, 2020 at 10:05 AM Christian Brauner ><[email protected]> wrote: >> >> This contains a single fix for all exported legacy fork helpers to >block >> accidental access to clone3() features in the upper 32 bits of their >> respective flags arguments. > >I've taken this pull, but I really think the minimal and more >straightforward fix would have been to just make do_fork(), >kernel_thread() and clone() change the flags field from "unsigned >long" to "unsigned int". > >I don't see why that wouldn't have fixed things, and it would have >been simpler and more obvious, I think. > >Doesn't matter, I guess. > > Linus
Seemed weird to me to change something that's been exposed to userspace for that long. Christian
