On Wed, Oct 10, 2007 at 12:35:41PM -0300, Mauro Carvalho Chehab wrote:
> Em Qua, 2007-10-10 às 00:18 -0400, Michael Krufky escreveu:
> >
> > Is this illegal as per kernel codingstyle?
>
> Yes, it is. CodingStyle states:
<rant>
No.. "Illegal" means prohibited by law. Its merely wrong 8)
</rant>
> The proper fix is just to replace the offended code by this:
>
> err=foo();
> if (error)
> goto error;
Lots of code uses
if ((err = foo()) < 0)
so I would'y worry too much. The split one however clearer and also
safer.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
