Hi Douglas, On 2020/5/14 8:23, Doug Anderson wrote: (SNIP) >> diff --git a/arch/arm64/kernel/kgdb.c b/arch/arm64/kernel/kgdb.c >> index 3910ac06c261..093ad9d2e5e6 100644 >> --- a/arch/arm64/kernel/kgdb.c >> +++ b/arch/arm64/kernel/kgdb.c >> @@ -230,7 +230,8 @@ int kgdb_arch_handle_exception(int exception_vector, int >> signo, >> kernel_prepare_single_step(&per_cpu(kgdb_ss_flags, >> raw_smp_processor_id()), linux_regs); >> kernel_enable_single_step(linux_regs); >> - } >> + } else >> + set_regs_spsr_ss(linux_regs); > > One slight nit is that my personal preference is that if one half of > an "if/else" needs braces then both halves should have braces. I Thanks for spotting it. Refer to Documentation/process/coding-style.rst, i will fix it in the v2.
> don't know what Catalin and Will's policies are, though. > > Other than that, this seems right to me. I will leave it to the > Catalin and Will folks to say if they'd rather have this call made > from a different place or if they're happy with where you've put it. > > Reviewed-by: Douglas Anderson <[email protected]> > Tested-by: Douglas Anderson <[email protected]> > Thanks, Wei
