Hi Dave, Thanks for the patchset.
On Tue, May 19, 2020 at 04:16:16AM +0300, Roman Kovalivskyi wrote: > From: Dave Stevenson <[email protected]> > > There's no way to query the subdevice for the supported > resolutions. Add set_fmt and get_fmt implementations. Since there's > only one format supported set_fmt does nothing and get returns single > format. > > Signed-off-by: Dave Stevenson <[email protected]> > Signed-off-by: Roman Kovalivskyi <[email protected]> > Reviewed-by: Jacopo Mondi <[email protected]> > --- > drivers/media/i2c/ov5647.c | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/drivers/media/i2c/ov5647.c b/drivers/media/i2c/ov5647.c > index e7d2e5b4ad4b..3e587eb0a30e 100644 > --- a/drivers/media/i2c/ov5647.c > +++ b/drivers/media/i2c/ov5647.c > @@ -463,8 +463,30 @@ static int ov5647_enum_mbus_code(struct v4l2_subdev *sd, > return 0; > } > > +static int ov5647_set_get_fmt(struct v4l2_subdev *sd, > + struct v4l2_subdev_pad_config *cfg, > + struct v4l2_subdev_format *format) > +{ > + struct v4l2_mbus_framefmt *fmt = &format->format; > + > + if (format->pad != 0) > + return -EINVAL; No need to check the pad, the caller already has checked for it. > + > + /* Only one format is supported, so return that */ > + memset(fmt, 0, sizeof(*fmt)); > + fmt->code = MEDIA_BUS_FMT_SBGGR8_1X8; > + fmt->colorspace = V4L2_COLORSPACE_SRGB; > + fmt->field = V4L2_FIELD_NONE; > + fmt->width = 640; > + fmt->height = 480; > + > + return 0; > +} > + > static const struct v4l2_subdev_pad_ops ov5647_subdev_pad_ops = { > .enum_mbus_code = ov5647_enum_mbus_code, > + .set_fmt = ov5647_set_get_fmt, > + .get_fmt = ov5647_set_get_fmt, > }; > > static const struct v4l2_subdev_ops ov5647_subdev_ops = { -- Kind regards, Sakari Ailus
