On Tue, 2020-05-19 at 12:25 +0200, Daniel Lezcano wrote: > On 19/05/2020 01:46, Srinivas Pandruvada wrote: > > On Mon, 2020-05-18 at 18:51 +0200, Daniel Lezcano wrote: > > > On 04/05/2020 20:16, Srinivas Pandruvada wrote: > > > > Add new attribute in the thermal syfs for setting temperature > > > > sampling > > > > interval when CONFIG_THERMAL_USER_EVENT_INTERFACE is defined. > > > > The > > > > default > > > > value is 0, which means no polling. > > > > > > > > At this interval user space will get an event > > > > THERMAL_TEMP_SAMPLE > > > > with > > > > temperature sample. This reuses existing polling mecahnism when > > > > polling > > > > or passive delay is specified during zone registry. To avoid > > > > interference > > > > with passive and polling delay, this new polling attribute > > > > can't be > > > > used > > > > for those zones. > > > > > > The userspace can get the temperature whenever it wants via the > > > temperature file. The polling is designed for a specific hardware > > > and > > > the slope of the temperature graphic. > > > > > > The userspace has the alternative of reading the temperature > > > based on > > > its own timer or wait for (and stick to) the thermal framework > > > sampling > > > rate. Adding a notification in the update is enough IMO. > > > > > The problem with this approach is that the user can't change > > sampling > > interval. Those polling intervals are fixed during thermal-zone > > register. Is there any way to change those defaults from user > > space? > > No, we can't but the userspace can decide when to read the > temperature > (via sysfs or netlink) and thus decide its own sampling rate.
Yes, if we poll for temperature from user space, no change is required neighter netlink nor kfifo. The average time to read CPU temperature and convert to int from sysfs takes 45us vs 7us for push via Kfifo. I haven't looked at your patches and checked this time. If it is comparable then netlink is better. > > Otherwise, we are talking about an userspace governor, so the > platform > is setup with the desired sampling rate + userspace governor. > > > Kernel can start with some long polling interval and user space can > > change close to some trip. > > Ok, let me rephrase it. This (big) comment encompass also patch 3/5. > > I understood now the initial need of adding user trip points. > > There are platforms where the interrupt mode does not exist so > setting > an user trip point does not set the interrupt for the closer > temperature, hence we end up with a kernel sampling rate and in this > case adding a trip point + new user sampling rate is pointless as the > userspace can poll the temperature at its convenient rate. > > If we summarize the different combinations we have: > > 1. monitoring : interrupt mode, mitigation : interrupt mode > > There are no thermal zone update until an interrupt fires. The > mitigation is based on trip point crossed. Yes. Basically daemon sleeps, till it gets a netlink notification currently. > > 2. monitoring : interrupt mode, mitigation : polling > > There are no thermal zone update until an interrupt fires. The > mitigation happens with a sampling rate specified with the polling > rate. > More complex than this. interrupt fires but it will fire flood for any change (+/- around threshold) so after the first trigger, just disable interrupt for an interval and start polling from user space as this is more efficient. > 3. monitoring : polling, mitigation : polling > > The thermal zone is updated at the polling rate, the mitigation > occurs > with an update at the second polling rate. > Yes. > IIUC, the RFC proposes to add a new type of temperature threshold, > followed a new polling rate to update the userspace. > > IMHO, it is not a good thing to delegate to the kernel what the > userspace can handle easily. > > I suggest: > > - Not add another polling rate. If the thermal zone has a polling > rate > or supports the interrupt mode, then the user trip point setup > succeed > otherwise it fails and up to the userspace to read the temperature at > its convenient rate. (Note multiple process may want to get > temperature, > so one should not set the rate of others). Fine. > > - Not add another temp threshold structure but add a new trip type > "user" and keep using the existing trip structures, so the > notification > can happen in the handle_trip_point function. The sysfs only reflects > the setup via the "trip_point_x_hyst", "trip_point_0_temp", > "trip_point_x_type" Fine. It is better than what we re-purpose a passive trip currently. > > - Do not use sysfs for setup but rely on the genetlink for one > message > setup instead of multiple sysfs file writing. Adding a trip point > will Fine. > > > What do you think? Looks good. Thanks, Srinivas > >
