On Sat, May 23, 2020 at 06:21:01AM -0700, Guenter Roeck wrote: > On Wed, May 13, 2020 at 06:18:40PM +0300, Heikki Krogerus wrote: > > In the function kobject_cleanup(), kobject_del(kobj) is > > called before the kobj->release(). That makes it possible to > > release the parent of the kobject before the kobject itself. > > > > To fix that, adding function __kboject_del() that does > > s/kboject/kobject/ > > > everything that kobject_del() does except release the parent > > reference. kobject_cleanup() then calls __kobject_del() > > instead of kobject_del(), and separately decrements the > > reference count of the parent kobject after kobj->release() > > has been called. > > > > Reported-by: Naresh Kamboju <[email protected]> > > Reported-by: kernel test robot <[email protected]> > > Fixes: 7589238a8cf3 ("Revert "software node: Simplify > > software_node_release() function"") > > Cc: Brendan Higgins <[email protected]> > > Cc: Randy Dunlap <[email protected]> > > Suggested-by: "Rafael J. Wysocki" <[email protected]> > > Signed-off-by: Heikki Krogerus <[email protected]> > > Reviewed-by: Rafael J. Wysocki <[email protected]> > > Reviewed-by: Brendan Higgins <[email protected]> > > Tested-by: Brendan Higgins <[email protected]> > > Acked-by: Randy Dunlap <[email protected]> > > Tested-by: Randy Dunlap <[email protected]> > > All my arm64be (arm64 big endian) boot tests crash with this patch > applied. Reverting it fixes the problem. Crash log and bisect results > (from pending-fixes branch) below.
Ugh, ok, just when I send Linus a pull request. Let me go fix that... greg k-h
