pm_runtime_get_sync() increments the runtime PM usage counter even
when it returns an error code. Thus a pairing decrement is needed on
the error handling path to keep the counter balanced.

Signed-off-by: Dinghao Liu <dinghao....@zju.edu.cn>
---
 drivers/media/platform/qcom/venus/venc.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/media/platform/qcom/venus/venc.c 
b/drivers/media/platform/qcom/venus/venc.c
index 9981a2a27c90..eefcfbb8f211 100644
--- a/drivers/media/platform/qcom/venus/venc.c
+++ b/drivers/media/platform/qcom/venus/venc.c
@@ -1169,7 +1169,7 @@ static int venc_open(struct file *file)
 
        ret = pm_runtime_get_sync(core->dev_enc);
        if (ret < 0)
-               goto err_free_inst;
+               goto err_put_sync;
 
        ret = venc_ctrl_init(inst);
        if (ret)
@@ -1214,7 +1214,6 @@ static int venc_open(struct file *file)
        venc_ctrl_deinit(inst);
 err_put_sync:
        pm_runtime_put_sync(core->dev_enc);
-err_free_inst:
        kfree(inst);
        return ret;
 }
-- 
2.17.1

Reply via email to