Previously, the -i option had two functions; load a symbol dump file,
and set the external_module flag.

I want to assign a dedicate option for each of them.

Going forward, the -i is used to load a symbol dump file, and the -e
to set the external_module flag.

With this, we will be able to use -i for loading in-kernel symbols.

Signed-off-by: Masahiro Yamada <[email protected]>
---

Changes in v2: None

 scripts/Makefile.modpost | 1 +
 scripts/mod/modpost.c    | 6 ++++--
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/scripts/Makefile.modpost b/scripts/Makefile.modpost
index a316095c843c..d14143b30b7a 100644
--- a/scripts/Makefile.modpost
+++ b/scripts/Makefile.modpost
@@ -81,6 +81,7 @@ include $(if $(wildcard $(KBUILD_EXTMOD)/Kbuild), \
 
 # modpost options for external modules
 MODPOST += \
+       -e \
        -i Module.symvers \
        $(addprefix -i ,$(KBUILD_EXTRA_SYMBOLS)) \
        -o $(KBUILD_EXTMOD)/Module.symvers
diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
index ebfc720ee5a4..0a24d2c501c1 100644
--- a/scripts/mod/modpost.c
+++ b/scripts/mod/modpost.c
@@ -2566,10 +2566,12 @@ int main(int argc, char **argv)
        struct dump_list *dump_read_start = NULL;
        struct dump_list **dump_read_iter = &dump_read_start;
 
-       while ((opt = getopt(argc, argv, "i:mnsT:o:awENd:")) != -1) {
+       while ((opt = getopt(argc, argv, "ei:mnsT:o:awENd:")) != -1) {
                switch (opt) {
-               case 'i':
+               case 'e':
                        external_module = 1;
+                       break;
+               case 'i':
                        *dump_read_iter =
                                NOFAIL(calloc(1, sizeof(**dump_read_iter)));
                        (*dump_read_iter)->file = optarg;
-- 
2.25.1

Reply via email to