On Sun, May 24, 2020 at 05:27:58PM -0700, Sargun Dhillon wrote:
> > if (addfd->fd >= 0) {
> > ret = replace_fd(addfd->fd, addfd->file, addfd->flags);
> > } else {
> > ret = get_unused_fd_flags(addfd->flags);
> > if (ret >= 0)
> > fd_install(ret, get_file(addfd->file));
^^^^^^^^> Wouldn't this result in consumption of reference in one case (fd_install), > and the fd still having a reference in the replace_fd case?

