On Sun, May 24, 2020 at 12:35:51PM +0000, Wei Yang wrote: > These two cases could be unified into one.
Care to provide a test case which supports your change? > Signed-off-by: Wei Yang <[email protected]> > --- > include/linux/bitops.h | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/include/linux/bitops.h b/include/linux/bitops.h > index 9acf654f0b19..5b5609e81a84 100644 > --- a/include/linux/bitops.h > +++ b/include/linux/bitops.h > @@ -206,10 +206,7 @@ static inline int get_count_order_long(unsigned long l) > { > if (l == 0UL) > return -1; > - else if (l & (l - 1UL)) > - return (int)fls_long(l); > - else > - return (int)fls_long(l) - 1; > + return (int)fls_long(--l); > } -- With Best Regards, Andy Shevchenko
