> On Wed, May 20, 2020 at 10:01 AM Dinghao Liu <[email protected]> wrote: > > > > pm_runtime_get_sync() increments the runtime PM usage counter even > > it returns an error code. Thus a pairing decrement is needed on > > the error handling path to keep the counter balanced. > > > > Signed-off-by: Dinghao Liu <[email protected]> > > --- > > drivers/power/supply/bq24190_charger.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/power/supply/bq24190_charger.c > > b/drivers/power/supply/bq24190_charger.c > > index 453d6332d43a..4f7c6b6abb56 100644 > > --- a/drivers/power/supply/bq24190_charger.c > > +++ b/drivers/power/supply/bq24190_charger.c > > @@ -481,8 +481,10 @@ static ssize_t bq24190_sysfs_store(struct device *dev, > > return ret; > > > > ret = pm_runtime_get_sync(bdi->dev); > > - if (ret < 0) > > + if (ret < 0) { > > + pm_runtime_put_autosuspend(bdi->dev); > > The autosuspend thing is not necessary here, because the suspend is > not going to work anyway due to the resume error, so this can be > _put_noidle(). > > You might as well do something like > > count = ret; > goto out; > > here and add an "out" label before the pm_runtime_mark_last_busy() call, > though. > > > return ret; > > + } > > > > ret = bq24190_write_mask(bdi, info->reg, info->mask, info->shift, > > v); > > if (ret) > > -- > > 2.17.1 > >
Thank you for your advice! I will fix this in the next version of patch. Regards, Dinghao
