Kaartic Sivaraam <kaartic.sivar...@gmail.com> writes: > Hi Junio, > > On 27-05-2020 00:17, Junio C Hamano wrote: >> Shourya Shukla (4): >> submodule--helper.c: Rename 'cb_foreach' to 'foreach_cb' >> gitfaq: files in .gitignore are tracked >> gitfaq: fetching and pulling a repository >> submodule: port subcommand 'set-url' from shell to C > > This is the only place where the `set-url` conversion from Shell to C > is mentioned. I wonder if it's enough or if it needs a little bit more > attention may be in the "Performance, Internal Implementation, > Development Support etc." as it is a conversion of a submodule > sub-command?
I'm not sure if it is worth the bits. It may matter _only_ if/when new implementaiton of set-url hurts the end-users by being buggy ;-)
