Hi Antoine, Thank you for the patch! Yet something to improve:
[auto build test ERROR on net-next/master] [also build test ERROR on next-20200526] [cannot apply to robh/for-next net/master linus/master v5.7-rc7] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Antoine-Tenart/net-phy-mscc-PHC-and-timestamping-support/20200528-005111 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git dc0f3ed1973f101508957b59e529e03da1349e09 config: m68k-allmodconfig (attached as .config) compiler: m68k-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot <l...@intel.com> All errors (new ones prefixed by >>, old ones prefixed by <<): In file included from arch/m68k/include/asm/io_mm.h:25, from arch/m68k/include/asm/io.h:8, from include/linux/scatterlist.h:9, from include/linux/dma-mapping.h:11, from include/linux/skbuff.h:31, from include/linux/ip.h:16, from drivers/net/phy/mscc/mscc_ptp.c:11: arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsb': arch/m68k/include/asm/raw_io.h:83:7: warning: variable '__w' set but not used [-Wunused-but-set-variable] 83 | ({u8 __w, __v = (b); u32 _addr = ((u32) (addr)); | ^~~ arch/m68k/include/asm/raw_io.h:430:3: note: in expansion of macro 'rom_out_8' 430 | rom_out_8(port, *buf++); | ^~~~~~~~~ arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsw': arch/m68k/include/asm/raw_io.h:86:8: warning: variable '__w' set but not used [-Wunused-but-set-variable] 86 | ({u16 __w, __v = (w); u32 _addr = ((u32) (addr)); | ^~~ arch/m68k/include/asm/raw_io.h:448:3: note: in expansion of macro 'rom_out_be16' 448 | rom_out_be16(port, *buf++); | ^~~~~~~~~~~~ arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsw_swapw': arch/m68k/include/asm/raw_io.h:90:8: warning: variable '__w' set but not used [-Wunused-but-set-variable] 90 | ({u16 __w, __v = (w); u32 _addr = ((u32) (addr)); | ^~~ arch/m68k/include/asm/raw_io.h:466:3: note: in expansion of macro 'rom_out_le16' 466 | rom_out_le16(port, *buf++); | ^~~~~~~~~~~~ In file included from include/linux/build_bug.h:5, from include/linux/bits.h:23, from include/linux/gpio/consumer.h:5, from drivers/net/phy/mscc/mscc_ptp.c:10: include/linux/scatterlist.h: In function 'sg_set_buf': arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra] 169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory) | ^~ include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~ include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~~~~~~~~~~ In file included from arch/m68k/include/asm/bug.h:32, from include/linux/bug.h:5, from include/linux/gpio/consumer.h:6, from drivers/net/phy/mscc/mscc_ptp.c:10: include/linux/dma-mapping.h: In function 'dma_map_resource': arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra] 169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory) | ^~ include/asm-generic/bug.h:139:27: note: in definition of macro 'WARN_ON_ONCE' 139 | int __ret_warn_once = !!(condition); | ^~~~~~~~~ arch/m68k/include/asm/page_mm.h:170:25: note: in expansion of macro 'virt_addr_valid' 170 | #define pfn_valid(pfn) virt_addr_valid(pfn_to_virt(pfn)) | ^~~~~~~~~~~~~~~ include/linux/dma-mapping.h:352:19: note: in expansion of macro 'pfn_valid' 352 | if (WARN_ON_ONCE(pfn_valid(PHYS_PFN(phys_addr)))) | ^~~~~~~~~ In file included from drivers/net/phy/mscc/mscc_ptp.c:18: include/linux/unaligned/be_byteshift.h: At top level: >> include/linux/unaligned/be_byteshift.h:41:19: error: redefinition of >> 'get_unaligned_be16' 41 | static inline u16 get_unaligned_be16(const void *p) | ^~~~~~~~~~~~~~~~~~ In file included from arch/m68k/include/asm/unaligned.h:18, from include/linux/etherdevice.h:24, from include/linux/if_vlan.h:11, from include/linux/filter.h:22, from include/net/sock.h:59, from include/net/inet_sock.h:22, from include/linux/udp.h:16, from drivers/net/phy/mscc/mscc_ptp.c:17: include/linux/unaligned/access_ok.h:23:28: note: previous definition of 'get_unaligned_be16' was here 23 | static __always_inline u16 get_unaligned_be16(const void *p) | ^~~~~~~~~~~~~~~~~~ In file included from drivers/net/phy/mscc/mscc_ptp.c:18: >> include/linux/unaligned/be_byteshift.h:46:19: error: redefinition of >> 'get_unaligned_be32' 46 | static inline u32 get_unaligned_be32(const void *p) | ^~~~~~~~~~~~~~~~~~ In file included from arch/m68k/include/asm/unaligned.h:18, from include/linux/etherdevice.h:24, from include/linux/if_vlan.h:11, from include/linux/filter.h:22, from include/net/sock.h:59, from include/net/inet_sock.h:22, from include/linux/udp.h:16, from drivers/net/phy/mscc/mscc_ptp.c:17: include/linux/unaligned/access_ok.h:28:28: note: previous definition of 'get_unaligned_be32' was here 28 | static __always_inline u32 get_unaligned_be32(const void *p) | ^~~~~~~~~~~~~~~~~~ In file included from drivers/net/phy/mscc/mscc_ptp.c:18: >> include/linux/unaligned/be_byteshift.h:51:19: error: redefinition of >> 'get_unaligned_be64' 51 | static inline u64 get_unaligned_be64(const void *p) | ^~~~~~~~~~~~~~~~~~ In file included from arch/m68k/include/asm/unaligned.h:18, from include/linux/etherdevice.h:24, from include/linux/if_vlan.h:11, from include/linux/filter.h:22, from include/net/sock.h:59, from include/net/inet_sock.h:22, from include/linux/udp.h:16, from drivers/net/phy/mscc/mscc_ptp.c:17: include/linux/unaligned/access_ok.h:33:28: note: previous definition of 'get_unaligned_be64' was here 33 | static __always_inline u64 get_unaligned_be64(const void *p) | ^~~~~~~~~~~~~~~~~~ In file included from drivers/net/phy/mscc/mscc_ptp.c:18: >> include/linux/unaligned/be_byteshift.h:56:20: error: redefinition of >> 'put_unaligned_be16' 56 | static inline void put_unaligned_be16(u16 val, void *p) | ^~~~~~~~~~~~~~~~~~ In file included from arch/m68k/include/asm/unaligned.h:18, from include/linux/etherdevice.h:24, from include/linux/if_vlan.h:11, from include/linux/filter.h:22, from include/net/sock.h:59, from include/net/inet_sock.h:22, from include/linux/udp.h:16, from drivers/net/phy/mscc/mscc_ptp.c:17: include/linux/unaligned/access_ok.h:53:29: note: previous definition of 'put_unaligned_be16' was here 53 | static __always_inline void put_unaligned_be16(u16 val, void *p) | ^~~~~~~~~~~~~~~~~~ In file included from drivers/net/phy/mscc/mscc_ptp.c:18: >> include/linux/unaligned/be_byteshift.h:61:20: error: redefinition of >> 'put_unaligned_be32' 61 | static inline void put_unaligned_be32(u32 val, void *p) | ^~~~~~~~~~~~~~~~~~ In file included from arch/m68k/include/asm/unaligned.h:18, from include/linux/etherdevice.h:24, from include/linux/if_vlan.h:11, from include/linux/filter.h:22, from include/net/sock.h:59, from include/net/inet_sock.h:22, from include/linux/udp.h:16, from drivers/net/phy/mscc/mscc_ptp.c:17: include/linux/unaligned/access_ok.h:58:29: note: previous definition of 'put_unaligned_be32' was here 58 | static __always_inline void put_unaligned_be32(u32 val, void *p) | ^~~~~~~~~~~~~~~~~~ In file included from drivers/net/phy/mscc/mscc_ptp.c:18: >> include/linux/unaligned/be_byteshift.h:66:20: error: redefinition of >> 'put_unaligned_be64' 66 | static inline void put_unaligned_be64(u64 val, void *p) | ^~~~~~~~~~~~~~~~~~ In file included from arch/m68k/include/asm/unaligned.h:18, from include/linux/etherdevice.h:24, from include/linux/if_vlan.h:11, from include/linux/filter.h:22, from include/net/sock.h:59, from include/net/inet_sock.h:22, from include/linux/udp.h:16, from drivers/net/phy/mscc/mscc_ptp.c:17: include/linux/unaligned/access_ok.h:63:29: note: previous definition of 'put_unaligned_be64' was here 63 | static __always_inline void put_unaligned_be64(u64 val, void *p) | ^~~~~~~~~~~~~~~~~~ drivers/net/phy/mscc/mscc_ptp.c:658:12: warning: 'vsc85xx_ts_engine_init' defined but not used [-Wunused-function] 658 | static int vsc85xx_ts_engine_init(struct phy_device *phydev, bool one_step) | ^~~~~~~~~~~~~~~~~~~~~~ vim +/get_unaligned_be16 +41 include/linux/unaligned/be_byteshift.h 064106a91be5e7 Harvey Harrison 2008-04-29 40 064106a91be5e7 Harvey Harrison 2008-04-29 @41 static inline u16 get_unaligned_be16(const void *p) 064106a91be5e7 Harvey Harrison 2008-04-29 42 { 19f747f7370fcf Bart Van Assche 2020-03-13 43 return __get_unaligned_be16(p); 064106a91be5e7 Harvey Harrison 2008-04-29 44 } 064106a91be5e7 Harvey Harrison 2008-04-29 45 064106a91be5e7 Harvey Harrison 2008-04-29 @46 static inline u32 get_unaligned_be32(const void *p) 064106a91be5e7 Harvey Harrison 2008-04-29 47 { 19f747f7370fcf Bart Van Assche 2020-03-13 48 return __get_unaligned_be32(p); 064106a91be5e7 Harvey Harrison 2008-04-29 49 } 064106a91be5e7 Harvey Harrison 2008-04-29 50 064106a91be5e7 Harvey Harrison 2008-04-29 @51 static inline u64 get_unaligned_be64(const void *p) 064106a91be5e7 Harvey Harrison 2008-04-29 52 { 19f747f7370fcf Bart Van Assche 2020-03-13 53 return __get_unaligned_be64(p); 064106a91be5e7 Harvey Harrison 2008-04-29 54 } 064106a91be5e7 Harvey Harrison 2008-04-29 55 064106a91be5e7 Harvey Harrison 2008-04-29 @56 static inline void put_unaligned_be16(u16 val, void *p) 064106a91be5e7 Harvey Harrison 2008-04-29 57 { 064106a91be5e7 Harvey Harrison 2008-04-29 58 __put_unaligned_be16(val, p); 064106a91be5e7 Harvey Harrison 2008-04-29 59 } 064106a91be5e7 Harvey Harrison 2008-04-29 60 064106a91be5e7 Harvey Harrison 2008-04-29 @61 static inline void put_unaligned_be32(u32 val, void *p) 064106a91be5e7 Harvey Harrison 2008-04-29 62 { 064106a91be5e7 Harvey Harrison 2008-04-29 63 __put_unaligned_be32(val, p); 064106a91be5e7 Harvey Harrison 2008-04-29 64 } 064106a91be5e7 Harvey Harrison 2008-04-29 65 064106a91be5e7 Harvey Harrison 2008-04-29 @66 static inline void put_unaligned_be64(u64 val, void *p) 064106a91be5e7 Harvey Harrison 2008-04-29 67 { 064106a91be5e7 Harvey Harrison 2008-04-29 68 __put_unaligned_be64(val, p); 064106a91be5e7 Harvey Harrison 2008-04-29 69 } 064106a91be5e7 Harvey Harrison 2008-04-29 70 :::::: The code at line 41 was first introduced by commit :::::: 064106a91be5e76cb42c1ddf5d3871e3a1bd2a23 kernel: add common infrastructure for unaligned access :::::: TO: Harvey Harrison <harvey.harri...@gmail.com> :::::: CC: Linus Torvalds <torva...@linux-foundation.org> --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
