Jaegeuk, could you please review this patch?
On 2020/5/26 9:55, Chao Yu wrote: > While compressed data writeback, we need to drop dirty pages like we did > for non-compressed pages if cp stops, however it's not needed to compress > any data in such case, so let's detect cp stop condition in > cluster_may_compress() to avoid redundant compressing and let following > f2fs_write_raw_pages() drops dirty pages correctly. > > Signed-off-by: Chao Yu <[email protected]> > --- > fs/f2fs/compress.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c > index bf152c0d79fe..a53578a89211 100644 > --- a/fs/f2fs/compress.c > +++ b/fs/f2fs/compress.c > @@ -849,6 +849,8 @@ static bool cluster_may_compress(struct compress_ctx *cc) > return false; > if (!f2fs_cluster_is_full(cc)) > return false; > + if (unlikely(f2fs_cp_error(F2FS_I_SB(cc->inode)))) > + return false; > return __cluster_may_compress(cc); > } > >
