Hi Andy, On Fri, May 29, 2020 at 04:32:10PM +0300, Andy Shevchenko wrote: > acpi_dev_get_resources() does perform the NULL pointer check against > ACPI companion device which is given as function parameter. Thus, > there is no need to duplicate this check in the caller. > > Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com> > --- > drivers/hwtracing/coresight/coresight-stm.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-stm.c > b/drivers/hwtracing/coresight/coresight-stm.c > index b908ca104645..673d2f56ed1e 100644 > --- a/drivers/hwtracing/coresight/coresight-stm.c > +++ b/drivers/hwtracing/coresight/coresight-stm.c > @@ -727,8 +727,6 @@ static int acpi_stm_get_stimulus_area(struct device *dev, > struct resource *res) > > struct acpi_device *adev = ACPI_COMPANION(dev); > > - if (!adev) > - return -ENODEV; > rc = acpi_dev_get_resources(adev, &res_list, NULL, NULL); > if (rc < 0) > return rc;
I have applied your patch. Thanks, Mathieu > -- > 2.26.2 >
