It makes sense to allow changes to get/set rx flow hash callback only
when rss is enabled. This patch restricts get_rss_hash_opts and
set_rss_hash_opts methods to allow querying and configuring different
Rx flow hash configurations only when rss is enabled

Signed-off-by: Ronak Doshi <dos...@vmware.com>
---
 drivers/net/vmxnet3/vmxnet3_ethtool.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/net/vmxnet3/vmxnet3_ethtool.c 
b/drivers/net/vmxnet3/vmxnet3_ethtool.c
index 6acaafe169de..def27afa1c69 100644
--- a/drivers/net/vmxnet3/vmxnet3_ethtool.c
+++ b/drivers/net/vmxnet3/vmxnet3_ethtool.c
@@ -899,6 +899,12 @@ vmxnet3_get_rxnfc(struct net_device *netdev, struct 
ethtool_rxnfc *info,
                        err = -EOPNOTSUPP;
                        break;
                }
+#ifdef VMXNET3_RSS
+               if (!adapter->rss) {
+                       err = -EOPNOTSUPP;
+                       break;
+               }
+#endif
                err = vmxnet3_get_rss_hash_opts(adapter, info);
                break;
        default:
@@ -919,6 +925,12 @@ vmxnet3_set_rxnfc(struct net_device *netdev, struct 
ethtool_rxnfc *info)
                err = -EOPNOTSUPP;
                goto done;
        }
+#ifdef VMXNET3_RSS
+       if (!adapter->rss) {
+               err = -EOPNOTSUPP;
+               goto done;
+       }
+#endif
 
        switch (info->cmd) {
        case ETHTOOL_SRXFH:
-- 
2.11.0

Reply via email to