On Tue, 02 Jun 2020, Neil Armstrong wrote: > On 20/05/2020 11:01, Lee Jones wrote: > > On Tue, 12 May 2020, Neil Armstrong wrote: > > > >> This Microcontroller is present on the Khadas VIM1, VIM2, VIM3 and Edge > >> boards. > >> > >> It has multiple boot control features like password check, power-on > >> options, power-off control and system FAN control on recent boards. > >> > >> This implements a very basic MFD driver with the fan control and User > >> NVMEM cells. > >> > >> Signed-off-by: Neil Armstrong <[email protected]> > >> --- > >> drivers/mfd/Kconfig | 14 ++++ > >> drivers/mfd/Makefile | 1 + > >> drivers/mfd/khadas-mcu.c | 143 +++++++++++++++++++++++++++++++++ > >> include/linux/mfd/khadas-mcu.h | 91 +++++++++++++++++++++ > >> 4 files changed, 249 insertions(+) > >> create mode 100644 drivers/mfd/khadas-mcu.c > >> create mode 100644 include/linux/mfd/khadas-mcu.h > >> > >> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > >> index 0a59249198d3..b95091397052 100644 > >> --- a/drivers/mfd/Kconfig > >> +++ b/drivers/mfd/Kconfig > >> @@ -2003,6 +2003,20 @@ config MFD_WCD934X > >> This driver provides common support WCD934x audio codec and its > >> associated Pin Controller, Soundwire Controller and Audio codec. > >> > >> +config MFD_KHADAS_MCU > >> + tristate "Support for Khadas System control Microcontroller" > >> + depends on I2C > >> + depends on OF || COMPILE_TEST > >> + select MFD_CORE > >> + select REGMAP_I2C > >> + help > >> + Support for the Khadas System control Microcontroller interface > >> present > >> + on their VIM and Edge boards. > >> + > >> + This driver provides common support for accessing the device, > >> + additional drivers must be enabled in order to use the functionality > >> + of the device. > > > > It would be good to describe the device here. > > Ok
If you agree with all review comments, there really is no need to reply. It's a waste of your time and anyone else who cares enough to search through looking for replies (as I just did). -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
