From: Matthias Brugger <[email protected]>

If we pass a driver without a name, we end up in a NULL pointer
derefernce. Check for the name before trying to register the driver.
As we don't have a driver name to point to in the error message, we dump
the call stack to make it easier to detect the buggy driver.

Reported-by: kernel test robot <[email protected]>
Signed-off-by: Matthias Brugger <[email protected]>
---
 drivers/base/driver.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/base/driver.c b/drivers/base/driver.c
index 57c68769e157..40fba959c140 100644
--- a/drivers/base/driver.c
+++ b/drivers/base/driver.c
@@ -149,6 +149,12 @@ int driver_register(struct device_driver *drv)
        int ret;
        struct device_driver *other;
 
+       if (!drv->name) {
+               pr_err("Driver has no name.\n");
+               dump_stack();
+               return -EINVAL;
+       }
+
        if (!drv->bus->p) {
                pr_err("Driver '%s' was unable to register with bus_type '%s' 
because the bus was not initialized.\n",
                           drv->name, drv->bus->name);
-- 
2.26.2

Reply via email to