Hi Geliang, On 08/06/2020 12:47, Geliang Tang wrote:
In MPTCPOPT_RM_ADDR option parsing, the pointer "ptr" pointed to the "Subtype" octet, the pointer "ptr+1" pointed to the "Address ID" octet:+-------+-------+---------------+ |Subtype|(resvd)| Address ID | +-------+-------+---------------+ | | ptr ptr+1 We should set mp_opt->rm_id to the value of "ptr+1", not "ptr". This patch will fix this bug. Fixes: 3df523ab582c ("mptcp: Add ADD_ADDR handling") Signed-off-by: Geliang Tang <[email protected]> --- Changes in v2: - Add "-net" subject and "Fixes" tag as Matt suggested.
Thanks for this v2! LGTM! Reviewed-by: Matthieu Baerts <[email protected]> Cheers, Matt -- Matthieu Baerts | R&D Engineer [email protected] Tessares SA | Hybrid Access Solutions www.tessares.net 1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium
