On Mon, 8 Jun 2020, Christoph Hellwig wrote: > On Wed, Jun 03, 2020 at 03:22:39PM -0700, Stefano Stabellini wrote: > > From: Stefano Stabellini <stefano.stabell...@xilinx.com> > > > > The parameter is unused in this patch. > > No functional changes. > > This looks weird. I'm pretty sure you are going to use it later, but > why not just add the argument when it actually is used?
It is just a matter of taste. Xen reviewers tend to ask for splitting patches into small chunks, especially large verbose non-functional changes like renaming or adding parameters. It is supposed to make it easier to review, to make it easier not to get distracted by renaming/non-functional changes while looking at the important changes. As a contributor, I am happy either way.
