On Sat, 13 Jun 2020 13:49:01 +0530 Mugilraj D <[email protected]> wrote:
> Resolve following checkpatch issue: > WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider > using octal permissions '0444'. Hmm. I guess that's just about worth tidying up, but (see inline...) Take into account that any change does have an impact on maintainability of a driver, and generally no one will take white space changes to drivers outside staging unless there is a good reason. Jonathan > > Signed-off-by: Mugilraj D <[email protected]> > --- > drivers/iio/accel/bma180.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/iio/accel/bma180.c b/drivers/iio/accel/bma180.c > index 265722e..b716347 100644 > --- a/drivers/iio/accel/bma180.c > +++ b/drivers/iio/accel/bma180.c > @@ -531,14 +531,13 @@ static ssize_t bma180_show_scale_avail(struct device > *dev, > } > > static IIO_DEVICE_ATTR(in_accel_filter_low_pass_3db_frequency_available, > - S_IRUGO, bma180_show_filter_freq_avail, NULL, 0); > + 0444, bma180_show_filter_freq_avail, NULL, 0); > > static IIO_DEVICE_ATTR(in_accel_scale_available, > - S_IRUGO, bma180_show_scale_avail, NULL, 0); > + 0444, bma180_show_scale_avail, NULL, 0); > > static struct attribute *bma180_attributes[] = { > - &iio_dev_attr_in_accel_filter_low_pass_3db_frequency_available. > - dev_attr.attr, > + > &iio_dev_attr_in_accel_filter_low_pass_3db_frequency_available.dev_attr.attr, This change is unrelated and basically just noise. > &iio_dev_attr_in_accel_scale_available.dev_attr.attr, > NULL, > };
