On Sat, 2020-06-13 at 14:56 +0800, David Gow wrote: > On Fri, Jun 12, 2020 at 5:55 AM Vitor Massaru Iha <vi...@massaru.org> > wrote: > > This adds the convertion of the runtime tests of check_*_overflow > > fuctions, > > from `lib/test_overflow.c`to KUnit tests. > > Nit: couple of minor typos here: convertion -> conversion, and > functions -> functions > > > The log similar to the one seen in dmesg running test_overflow can > > be > > seen in `test.log`. > > > > Signed-off-by: Vitor Massaru Iha <vi...@massaru.org> > > I've tested that this builds and runs on my system, and it all seems > to be working fine! > > Tested-by: David Gow <david...@google.com> > > > --- > > lib/Kconfig.debug | 17 ++ > > lib/Makefile | 1 + > > lib/kunit_overflow_test.c | 590 > > ++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 608 insertions(+) > > create mode 100644 lib/kunit_overflow_test.c > > Echoing what Brendan and Kees mentioned, it'd be nicer to have this > replace the existing test, both because there's no need for redundant > tests (one will get out-of-date), and so that we can have a nice diff > showing the changes made as part of the conversion. > > Cheers, > -- David
Thank you David, I will fix your suggestions.
