Hi Stanimir, I love your patch! Perhaps something to improve:
[auto build test WARNING on linuxtv-media/master] [also build test WARNING on linux/master linus/master v5.8-rc1 next-20200616] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Stanimir-Varbanov/Add-two-new-v4l-controls-and-implementation/20200616-203311 base: git://linuxtv.org/media_tree.git master config: riscv-allyesconfig (attached as .config) compiler: riscv64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=riscv If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> All warnings (new ones prefixed by >>, old ones prefixed by <<): drivers/media/platform/qcom/venus/hfi_cmds.c: In function 'pkt_session_set_property_6xx': >> drivers/media/platform/qcom/venus/hfi_cmds.c:1225:8: warning: variable >> 'prop_data' set but not used [-Wunused-but-set-variable] 1225 | void *prop_data; | ^~~~~~~~~ vim +/prop_data +1225 drivers/media/platform/qcom/venus/hfi_cmds.c 1220 1221 static int 1222 pkt_session_set_property_6xx(struct hfi_session_set_property_pkt *pkt, 1223 void *cookie, u32 ptype, void *pdata) 1224 { > 1225 void *prop_data; 1226 1227 if (!pkt || !cookie || !pdata) 1228 return -EINVAL; 1229 1230 prop_data = &pkt->data[1]; 1231 1232 pkt->shdr.hdr.size = sizeof(*pkt); 1233 pkt->shdr.hdr.pkt_type = HFI_CMD_SESSION_SET_PROPERTY; 1234 pkt->shdr.session_id = hash32_ptr(cookie); 1235 pkt->num_properties = 1; 1236 pkt->data[0] = ptype; 1237 1238 switch (ptype) { 1239 case HFI_PROPERTY_PARAM_VENC_RATE_CONTROL: { 1240 u32 *in = pdata; 1241 1242 switch (*in) { 1243 case HFI_RATE_CONTROL_OFF: 1244 case HFI_RATE_CONTROL_CBR_CFR: 1245 case HFI_RATE_CONTROL_CBR_VFR: 1246 case HFI_RATE_CONTROL_VBR_CFR: 1247 case HFI_RATE_CONTROL_VBR_VFR: 1248 case HFI_RATE_CONTROL_CQ: 1249 break; 1250 default: 1251 return -EINVAL; 1252 } 1253 1254 pkt->data[1] = *in; 1255 pkt->shdr.hdr.size += sizeof(u32) * 2; 1256 break; 1257 } 1258 default: 1259 return pkt_session_set_property_4xx(pkt, cookie, ptype, pdata); 1260 } 1261 1262 return 0; 1263 } 1264 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
