> From: Anson Huang <anson.hu...@nxp.com> > Sent: Wednesday, June 17, 2020 8:32 PM > > > Subject: RE: [PATCH V2 1/9] clk: composite: Export > > clk_hw_register_composite() > > > > > From: Anson Huang <anson.hu...@nxp.com> > > > Sent: Tuesday, June 9, 2020 3:32 PM > > > > > > Export clk_hw_register_composite() to support user built as module. > > > > > > ERROR: modpost: "clk_hw_register_composite" > > > [drivers/clk/imx/mxc-clk.ko] undefined! > > > scripts/Makefile.modpost:111: recipe for target 'Module.symvers' > > > failed > > > make[1]: *** [Module.symvers] Error 1 > > > make[1]: *** Deleting file 'Module.symvers' > > > Makefile:1384: recipe for target 'modules' failed > > > make: *** [modules] Error 2 > > > > > > Signed-off-by: Anson Huang <anson.hu...@nxp.com> > > > --- > > > No change. > > > --- > > > drivers/clk/clk-composite.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/clk/clk-composite.c > > > b/drivers/clk/clk-composite.c index 7376f57..2ddb54f 100644 > > > --- a/drivers/clk/clk-composite.c > > > +++ b/drivers/clk/clk-composite.c > > > @@ -328,6 +328,7 @@ struct clk_hw *clk_hw_register_composite(struct > > > device *dev, const char *name, > > > rate_hw, rate_ops, gate_hw, > > > gate_ops, flags); > > > } > > > +EXPORT_SYMBOL_GPL(clk_hw_register_composite); > > > > > > struct clk_hw *clk_hw_register_composite_pdata(struct device *dev, > > > const char *name, > > > > I guess you'd better add this one as well. > > I did NOT see this is used in upstream i.MX clock driver, from my test, it is > not > necessary so far. >
Normally we could export them together in case it will be used in the future assuming your patch is making clk-composite be able to be used by modules. Anyway, it depends on Stephen's preference. Regards Aisheng > Anson
