On Thu, Jun 18, 2020 at 10:14:26PM +0800, Xiaoming Ni wrote:
> Build error on s390:
> arch/s390/kernel/entry.o: in function `sys_call_table_emu':
> >> (.rodata+0x1288): undefined reference to `__s390_'
>
> In commit ("All arch: remove system call sys_sysctl")
> 148 common fdatasync sys_fdatasync
> sys_fdatasync
> -149 common _sysctl sys_sysctl
> compat_sys_sysctl
> +149 common _sysctl sys_ni_syscall
> 150 common mlock sys_mlock
> sys_mlock
>
> After the patch is integrated, there is a format error in the generated
> arch/s390/include/generated/asm/syscall_table.h:
> SYSCALL(sys_fdatasync, sys_fdatasync)
> SYSCALL(sys_ni_syscall,) /* cause build error */
> SYSCALL(sys_mlock,sys_mlock)
>
> According to the guidance of Heiko Carstens, use "-" to fill the empty system
> call
> Similarly, modify tools/perf/arch/s390/entry/syscalls/syscall.tbl.
>
> Fixes: ("All arch: remove system call sys_sysctl")
> Fixes:
> https://lore.kernel.org/linuxppc-dev/[email protected]/
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Xiaoming Ni <[email protected]>
>
> changes in v2:
> use "-" to fill the empty system call
>
> v1:
> https://lore.kernel.org/lkml/[email protected]/
> ---
> arch/s390/kernel/syscalls/syscall.tbl | 2 +-
> tools/perf/arch/s390/entry/syscalls/syscall.tbl | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Acked-by: Heiko Carstens <[email protected]>
