On Fri, Jun 26, 2020 at 02:05:20PM +0100, Lee Jones wrote: > lkdtm_DOUBLE_FAULT() already has internal logic to handle > !CONFIG_X86_32. Compiling out the prototype actually prevents > that logic from being useful. > > Fixes the following W=1 warning: > > drivers/misc/lkdtm/bugs.c: At top level: > drivers/misc/lkdtm/bugs.c:420:6: warning: no previous prototype for > ‘lkdtm_DOUBLE_FAULT’ [-Wmissing-prototypes] > 420 | void lkdtm_DOUBLE_FAULT(void) > | ^~~~~~~~~~~~~~~~~~ > > Cc: Kees Cook <[email protected]> > Signed-off-by: Lee Jones <[email protected]>
Thanks! This change is actually already part of another patch and is waiting for Greg to pick up: https://lore.kernel.org/lkml/[email protected]/ -- Kees Cook
