Using ctrl-F ('Find') would not find 'unknown' because it matches id zero.
Fix by excluding id zero from selection.

Example:
 $ perf record -e intel_pt//u uname
 Linux
 [ perf record: Woken up 1 times to write data ]
 [ perf record: Captured and wrote 0.034 MB perf.data ]
 $ perf script --itrace=bep -s 
~/libexec/perf-core/scripts/python/export-to-sqlite.py perf.data.db branches 
calls
 2020-06-26 15:32:14.928997 Creating database ...
 2020-06-26 15:32:14.933971 Writing records...
 2020-06-26 15:32:15.535251 Adding indexes
 2020-06-26 15:32:15.542993 Dropping unused tables
 2020-06-26 15:32:15.549716 Done
 $ python3 ~/libexec/perf-core/scripts/python/exported-sql-viewer.py 
perf.data.db

 Select: Reports -> Context-Sensitive Call Graph
 Press: Ctrl-F
 Enter: unknown
 Press: Enter

 Before: gets stuck
 After: tree is expanded to line showing 'unknown'

Signed-off-by: Adrian Hunter <[email protected]>
Fixes: 254c0d820b86d ("perf scripts python: exported-sql-viewer.py: Factor out 
CallGraphModelBase")
Cc: [email protected]
---
 tools/perf/scripts/python/exported-sql-viewer.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/perf/scripts/python/exported-sql-viewer.py 
b/tools/perf/scripts/python/exported-sql-viewer.py
index 4be7cb68c8bb..e0c90aeff15e 100755
--- a/tools/perf/scripts/python/exported-sql-viewer.py
+++ b/tools/perf/scripts/python/exported-sql-viewer.py
@@ -768,7 +768,8 @@ class CallGraphModel(CallGraphModelBase):
                                                " FROM calls"
                                                " INNER JOIN call_paths ON 
calls.call_path_id = call_paths.id"
                                                " INNER JOIN symbols ON 
call_paths.symbol_id = symbols.id"
-                                               " WHERE symbols.name" + match +
+                                               " WHERE calls.id <> 0"
+                                               " AND symbols.name" + match +
                                                " GROUP BY comm_id, thread_id, 
call_path_id"
                                                " ORDER BY comm_id, thread_id, 
call_path_id")
 
-- 
2.17.1

Reply via email to