Hi Aubrey, On Mon, Jun 29, 2020 at 8:34 AM Li, Aubrey <[email protected]> wrote: > > > - Load balancing/migration changes ignores group weights: > > - > > https://lwn.net/ml/linux-kernel/[email protected] > > According to Aaron's response below: > https://lwn.net/ml/linux-kernel/[email protected]/ > > The following logic seems to be helpful for Aaron's case. > > + /* > + * Ignore cookie match if there is a big imbalance between the src rq > + * and dst rq. > + */ > + if ((src_rq->cfs.h_nr_running - rq->cfs.h_nr_running) > 1) > + return true; > > I didn't see any other comments on the patch at here: > https://lwn.net/ml/linux-kernel/[email protected]/ > > Do we have another way to address this issue? > We do not have a clear fix for this yet, and did not get much time to work on this.
I feel that the above change would not be fixing the real issue. The issue is about not considering the weight of the group when we try to load balance, but the above change is checking only the nr_running which might not work always. I feel that we should fix the real issue in v6 and probably hold on to adding the workaround fix in the interim. I have added a TODO specifically for this bug in v6. What do you think? Thanks, Vineeth
