From: Dave Stevenson <dave.steven...@raspberrypi.org>

There is an enum for the errors that the VPU can return.
port_parameter_get was negating that value, but also using -EINVAL
from the Linux error codes.
Pass the VPU error code as positive values. Should the function
need to pass a Linux failure, then return that as negative.

Signed-off-by: Dave Stevenson <dave.steven...@raspberrypi.org>
Signed-off-by: Jacopo Mondi <jac...@jmondi.org>
Signed-off-by: Nicolas Saenz Julienne <nsaenzjulie...@suse.de>
---
 drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c 
b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
index efdf30b9edf9..7fb502f90a89 100644
--- a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
+++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
@@ -1270,7 +1270,8 @@ static int port_parameter_get(struct vchiq_mmal_instance 
*instance,
                goto release_msg;
        }
 
-       ret = -rmsg->u.port_parameter_get_reply.status;
+       ret = rmsg->u.port_parameter_get_reply.status;
+
        /* port_parameter_get_reply.size includes the header,
         * whilst *value_size doesn't.
         */
-- 
2.27.0

Reply via email to