On Fri, 26 Jun 2020 21:13:53 +0530, Sumit Gupta wrote:
> To do frequency scaling on all CPUs within T194 CPU Complex, we need
> to query BPMP for data on valid operating points. Document a compatible
> string under 'cpus' node to represent the CPU Complex for binding drivers
> like cpufreq which don't have their node or CPU Complex node to bind to.
> Also, document a property to point to the BPMP device that can be queried
> for all CPUs.
>
> Signed-off-by: Sumit Gupta <[email protected]>
> ---
> Documentation/devicetree/bindings/arm/cpus.yaml | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/cpus.yaml:
properties:nvidia,bpmp: Additional properties are not allowed ('descrption'
was unexpected)
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/cpus.yaml:
properties:nvidia,bpmp: 'descrption' is not one of ['$ref', 'additionalItems',
'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default',
'dependencies', 'deprecated', 'description', 'else', 'enum',
'exclusiveMaximum', 'exclusiveMinimum', 'items', 'if', 'minItems', 'minimum',
'maxItems', 'maximum', 'multipleOf', 'not', 'oneOf', 'pattern',
'patternProperties', 'properties', 'required', 'then', 'type', 'typeSize',
'unevaluatedProperties', 'uniqueItems']
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/cpus.yaml:
properties:nvidia,bpmp: {'$ref': '/schemas/types.yaml#/definitions/phandle',
'descrption': 'Specifies the bpmp node that needs to be queried to
get\noperating point data for all CPUs.\n\nOptional for NVIDIA Tegra194 Carmel
CPUs\n'} is not valid under any of the given schemas (Possible causes of the
failure):
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/cpus.yaml:
properties:nvidia,bpmp: 'description' is a required property
Documentation/devicetree/bindings/Makefile:20: recipe for target
'Documentation/devicetree/bindings/arm/cpus.example.dts' failed
make[1]: *** [Documentation/devicetree/bindings/arm/cpus.example.dts] Error 1
make[1]: *** Waiting for unfinished jobs....
Makefile:1347: recipe for target 'dt_binding_check' failed
make: *** [dt_binding_check] Error 2
See https://patchwork.ozlabs.org/patch/1317775
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure dt-schema is up to date:
pip3 install git+https://github.com/devicetree-org/dt-schema.git@master
--upgrade
Please check and re-submit.
