----- Ursprüngliche Mail ----- > Von: "Christophe Kerello" <[email protected]> > An: "Richard Weinberger" <[email protected]> > CC: "Miquel Raynal" <[email protected]>, "richard" <[email protected]>, > "Vignesh Raghavendra" <[email protected]>, > "Rob Herring" <[email protected]>, "Mark Rutland" <[email protected]>, > [email protected], "Alexandre Torgue" > <[email protected]>, "Marek Vasut" <[email protected]>, "devicetree" > <[email protected]>, "linux-kernel" > <[email protected]>, "linux-mtd" <[email protected]>, > [email protected] > Gesendet: Dienstag, 30. Juni 2020 11:35:38 > Betreff: Re: [PATCH v5 4/6] memory: stm32-fmc2-ebi: add STM32 FMC2 EBI > controller driver
> Hi Richard, > > On 6/30/20 11:13 AM, Richard Weinberger wrote: >> On Fri, Jun 12, 2020 at 5:24 PM Christophe Kerello >> <[email protected]> wrote: >>> >>> The driver adds the support for the STMicroelectronics FMC2 EBI controller >>> found on STM32MP SOCs. >>> >>> Signed-off-by: Christophe Kerello <[email protected]> >>> --- >>> + if (!IS_ERR(rstc)) { >>> + reset_control_assert(rstc); >>> + reset_control_deassert(rstc); >> >> Shouldn't there be a small delay between assert and deassert? >> Other than that the code looks good to me. >> > > Even if I have currently not met any issue, I will add a udelay(2) to be > safe. It will be part of v6. Well, if it works and you are sure, please go for it. Like I said, I'm no expert in this. I just noticed that other users add a delay and wondered. Thanks, //richard
