Hi, On Tue, Jun 30, 2020 at 1:30 AM Cengiz Can <cen...@kernel.wtf> wrote: > > `kdb_msg_write` operates on a global `struct kgdb_io *` called > `dbg_io_ops`. > > It's initialized in `debug_core.c` and checked throughout the debug > flow. > > There's a null check in `kdb_msg_write` which triggers static analyzers > and gives the (almost entirely wrong) impression that it can be null. > > Coverity scanner caught this as CID 1465042. > > I have removed the unnecessary null check and eliminated false-positive > forward null dereference warning. > > Signed-off-by: Cengiz Can <cen...@kernel.wtf> > --- > kernel/debug/kdb/kdb_io.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-)
Reviewed-by: Douglas Anderson <diand...@chromium.org> Tested-by: Douglas Anderson <diand...@chromium.org>
