Hi Jarkko, > Hi Jakko, I apologize for mis-spelling of your name. Same mistake also appears in my another reply to "[PATCH v3 1/2] tpm: tis: add support for MMIO TPM on SynQuacer"
On Thu, 9 Jul 2020 at 08:34, Masahisa Kojima <[email protected]> wrote: > > Hi Jakko, > > > Overally the code looks great. You've run it through checkpatch.pl? > > Yes, I have run checkpatch.pl and removed errors. > > Regards, > Masahisa > > On Thu, 9 Jul 2020 at 01:20, Jarkko Sakkinen > <[email protected]> wrote: > > > > On Wed, Jul 08, 2020 at 10:14:22PM +0900, Masahisa Kojima wrote: > > > This adds support for driving the TPM on Socionext SynQuacer platform > > > using the driver for a memory mapped TIS frame. > > > > > > v3: > > > - prepare new module to handle TPM MMIO access on SynQuacer platform > > > > > > v2: > > > - don't use read/write_bytes() to implement read/write16/32 since that > > > uses > > > the wrong address > > > > > > Cc: [email protected] > > > Cc: [email protected] > > > Cc: [email protected] > > > Cc: [email protected] > > > Cc: [email protected] > > > Cc: [email protected] > > > Cc: [email protected] > > > Cc: [email protected] > > > > > > Masahisa Kojima (2): > > > tpm: tis: add support for MMIO TPM on SynQuacer > > > dt-bindings: Add SynQucer TPM MMIO as a trivial device > > > > > > .../devicetree/bindings/trivial-devices.yaml | 2 + > > > drivers/char/tpm/Kconfig | 12 ++ > > > drivers/char/tpm/Makefile | 1 + > > > drivers/char/tpm/tpm_tis_synquacer.c | 196 ++++++++++++++++++ > > > 4 files changed, 211 insertions(+) > > > create mode 100644 drivers/char/tpm/tpm_tis_synquacer.c > > > > > > -- > > > 2.20.1 > > > > > > > Overally the code looks great. You've run it through checkpatch.pl? > > > > /Jarkko
