If platform_driver_register() fails within vpss_init() resources are not
cleaned up. The patch fixes this issue by introducing the corresponding
error handling.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Evgeny Novikov <novi...@ispras.ru>
---
 drivers/media/platform/davinci/vpss.c | 20 ++++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)

diff --git a/drivers/media/platform/davinci/vpss.c 
b/drivers/media/platform/davinci/vpss.c
index d38d2bbb6f0f..7000f0bf0b35 100644
--- a/drivers/media/platform/davinci/vpss.c
+++ b/drivers/media/platform/davinci/vpss.c
@@ -505,19 +505,31 @@ static void vpss_exit(void)
 
 static int __init vpss_init(void)
 {
+       int ret;
+
        if (!request_mem_region(VPSS_CLK_CTRL, 4, "vpss_clock_control"))
                return -EBUSY;
 
        oper_cfg.vpss_regs_base2 = ioremap(VPSS_CLK_CTRL, 4);
        if (unlikely(!oper_cfg.vpss_regs_base2)) {
-               release_mem_region(VPSS_CLK_CTRL, 4);
-               return -ENOMEM;
+               ret = -ENOMEM;
+               goto err_ioremap;
        }
 
        writel(VPSS_CLK_CTRL_VENCCLKEN |
-                    VPSS_CLK_CTRL_DACCLKEN, oper_cfg.vpss_regs_base2);
+              VPSS_CLK_CTRL_DACCLKEN, oper_cfg.vpss_regs_base2);
+
+       ret = platform_driver_register(&vpss_driver);
+       if (ret)
+               goto err_pd_register;
+
+       return 0;
 
-       return platform_driver_register(&vpss_driver);
+err_pd_register:
+       iounmap(oper_cfg.vpss_regs_base2);
+err_ioremap:
+       release_mem_region(VPSS_CLK_CTRL, 4);
+       return ret;
 }
 subsys_initcall(vpss_init);
 module_exit(vpss_exit);
-- 
2.16.4

Reply via email to