On Fri, Jul 10, 2020 at 09:24:45AM +0200, H. Nikolaus Schaller wrote: > This reverts commit a6030d71e62d3e0e270bf3b7fb48d32a636732db. > > which was applied to v5.4.49. This ends in a compile issue: > > CC drivers/pwm/pwm-jz4740.o - due to target missing > drivers/pwm/pwm-jz4740.c: In function 'jz4740_pwm_apply': > drivers/pwm/pwm-jz4740.c:111:28: error: 'rate' undeclared (first use in this > function) > tmp = (unsigned long long)rate * state->duty_cycle; > ^ > drivers/pwm/pwm-jz4740.c:111:28: note: each undeclared identifier is reported > only once for each function it appears in > make: *** [drivers/pwm/pwm-jz4740.o] Error 1 > > v5.5 and later include the required additional patches to define > the rate variable.
So 9017dc4fbd59 ("pwm: jz4740: Enhance precision in calculation of duty cycle") which is in v5.8-rc1 was backported to stable: v5.4.49 (as commit a6030d71e62d3e0e270bf3b7fb48d32a636732db) v5.7.5 (as commit e0e71bb7852142a18fb829da419013bb6da9ed3f) However 9017dc4fbd59 depends on ce1f9cece057 ("pwm: jz4740: Use clocks from TCU driver") (which in mainline comes before 9017dc4fbd59 as it's included in v5.7-rc1). As ce1f9cece057 was not backported to v5.4.x, this must either be done, or we need to patch that. Will reply with a suggested change. In v5.7.x there is no problem. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Description: PGP signature