Indeed according to the clk API if clk_round_rate() has successfully
accepted a rate, then in order setup the clock with value returned by the
clk_round_rate() the clk_set_rate() method must be called with the
original rate value.

Suggested-by: Russell King <li...@armlinux.org.uk>
Signed-off-by: Serge Semin <sergey.se...@baikalelectronics.ru>

---

Changelog v8:
- This is a new patch created by the Russell King suggestion.
---
 drivers/tty/serial/8250/8250_dw.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/tty/serial/8250/8250_dw.c 
b/drivers/tty/serial/8250/8250_dw.c
index 12866083731d..c1511f9244bb 100644
--- a/drivers/tty/serial/8250/8250_dw.c
+++ b/drivers/tty/serial/8250/8250_dw.c
@@ -275,15 +275,15 @@ dw8250_do_pm(struct uart_port *port, unsigned int state, 
unsigned int old)
 static void dw8250_set_termios(struct uart_port *p, struct ktermios *termios,
                               struct ktermios *old)
 {
-       unsigned int baud = tty_termios_baud_rate(termios);
+       unsigned long newrate = tty_termios_baud_rate(termios) * 16;
        struct dw8250_data *d = to_dw8250_data(p->private_data);
        long rate;
        int ret;
 
        clk_disable_unprepare(d->clk);
-       rate = clk_round_rate(d->clk, baud * 16);
+       rate = clk_round_rate(d->clk, newrate);
        if (rate > 0) {
-               ret = clk_set_rate(d->clk, rate);
+               ret = clk_set_rate(d->clk, newrate);
                if (!ret)
                        p->uartclk = rate;
        }
-- 
2.26.2

Reply via email to